Issue181

Title Newly hired Merc wingmen dock after hiring.
Priority urgent Status testing
Superseder Nosy List Jesse
Assigned To Jesse Topics

Created on 2012-01-12.12:58:20 by Jesse, last changed 2012-01-19.11:27:15 by Jesse.

Messages
msg1127 (view) Author: Jesse Date: 2012-01-19.11:27:15
I believe this is fixed now.  I changed the way ships were selected to dock, and 
turned off the ability to hire ships that were docking.

I also checked the Lpoint maneuvering case, and it is not a problem.  Ships can 
be hired while an operation is moving through an lpoint without an issues (that 
I have seen)
msg1124 (view) Author: Jesse Date: 2012-01-16.12:36:04
I just realised another important case where operation ships are 'individualized' 
is in Lpoint maneuvering.  I will likely need to turn off hiring there too.  I 
might as well just shut off hiring outside stations.
msg1123 (view) Author: Jesse Date: 2012-01-16.11:57:38
I allied the solution, but mid way through a conversation the docking order can be 
applied, and the original bug remains.  May need a different solution.
msg1122 (view) Author: Jesse Date: 2012-01-15.12:33:21
I think my solution will work, and hopefully there will not be any further areas 
where this is necessary, because the SelectShipToDock case is the only case (I 
think) where a ship in the group is individualized.  Elsewhere the operation is 
always acting as a group or following the group leader.
msg1121 (view) Author: Jesse Date: 2012-01-15.04:28:58
My quick solution to this will be to simply turn off ship hiring during docking 
procedures.  Hopefully that will take care of the bulk of the issue.  However, 
hiring a ship during other cases might cause the same issue, so a better long 
term solution might be in order. 

Perhaps the Check_Nearby case could be used to watch for ships being hired away, 
and even give a reaction to the event.  
'so long pal, been good traveling with you' or something like that.
msg1120 (view) Author: Jesse Date: 2012-01-15.04:07:56
This one keeps getting worse.  The operation that the hired wingmen left can get 
stuck in a state, if for example, it is waiting for a wingman to return from a 
docking maneuver, but that ship was hired away.  The hired away ship will never 
return, so the operation will be stuck in a state for ever.
msg1119 (view) Author: Jesse Date: 2012-01-15.04:00:04
Not a quick fix on this one.  The operation continuously issues dock orders to 
the wingman, regardless of whether the wingman is in the operation or not.  So 
the issuing of orders overlaps, and the operations dock order will continue to 
override the player issued wingman orders until the order is completed.  This 
may happen in other cases, where the operation is issuing orders to a wingman 
without first checking if the wingman is still actually in the operation....
msg1118 (view) Author: Jesse Date: 2012-01-12.12:58:20
Many Free type operations have a function to periodically dock with a station 
for r and r.  If a player hires a wingman from this operation that was selected 
to do a dock, the wingman will continue to carry through with this order even 
after being given new orders by the player.  This often results in the ship 
being left behind, docked to the station, whilst the player was expecting them 
to be formatted to them.
History
Date User Action Args
2012-01-19 11:27:15Jessesetstatus: chatting -> testing
messages: + msg1127
2012-01-16 12:36:04Jessesetmessages: + msg1124
2012-01-16 11:57:38Jessesetmessages: + msg1123
2012-01-15 12:33:21Jessesetmessages: + msg1122
2012-01-15 04:28:58Jessesetmessages: + msg1121
2012-01-15 04:07:56Jessesetmessages: + msg1120
2012-01-15 04:00:04Jessesetpriority: bug -> urgent
status: unread -> chatting
messages: + msg1119
2012-01-12 12:58:20Jessecreate