Issue43

Title Mines have station sound effects
Priority bug Status done-cbb
Superseder Nosy List Jesse, jon
Assigned To Jesse Topics

Created on 2006-11-04.18:49:19 by Jesse, last changed 2012-01-03.11:55:25 by Jesse.

Messages
msg1099 (view) Author: Jesse Date: 2012-01-03.11:55:25
Mine Stations have been given a pseudo 'station' for Normal status, so and they 
have an LDSI field.  Empty and player owned mine stations have no pseudo 'station' 
and no LDSI field.  So this should solve this issue.
msg138 (view) Author: Jesse Date: 2006-11-05.22:48:22
I think you got all the fixes right.  There might just be a conceptual
difference here.  I have assumed that a faction held mine, regardless of the
fact that it is a functioning station, should not have a station 'broadcast'
sound because it is in fact, in appearence, an asteroid.

However, I think you may have assumed that that asteroid, regardless of the fact
that it appears as an asteroid, is in fact, a station.  Thus, it gets a sound
effect.

So the real problem may be that we have faction owned stations, that lack any
real, visual, station parts/appearence?
msg135 (view) Author: jon Date: 2006-11-05.10:16:49
I remember making a bunch of fixes to mine sounds last spring. I guess I never
got it right. 

Can you define what the correct behavior for sounds and stations should be? And
then I will code to that behavior. I think once the required behavior is
documented, it will put an end up my misunderstanding what should happen.

For reference I am attaching two lists. The first is the Station Status. This is
how the code sees a station. Mines begin as Empty, just like abandond stations.

The second list is the station category. All stations types are sorted into one
(and only one) category. I am putting these here so when the music specification
is written, it can be based on these categories. (if near a mine, and it is
Empty, then have NO music (get a clue jon)). Hah.

ESS_Destroyed: Station is only debris field.
   ESS_Empty:     Station exists, but abandond.
   ESS_Building:  Station under construction.
   ESS_Normal:    Station intact and operating.
   ESS_Leaving:   Station is being abandond.
   ESS_Fleeing:   Station was destroyed, survivors fleeing.
   ESS_NeverBuilt: Station has not yet been created.

   ESC_Invalid = 0,
   ESC_Mine = 1,
   ESC_Process = 2,
   ESC_Manufacture = 4, 
   ESC_Research = 8,
   ESC_Habitat = 16,
   ESC_Headquarters = 32,
   ESC_Pirate = 64,
   ESC_Transport = 128,
   ESC_Government = 256,
   ESC_Military = 512
msg126 (view) Author: Jesse Date: 2006-11-04.18:49:19
Mines still have the station broadcast sound.  They should have no sounds.  To
confirm, go to any mine, owned by a faction, and you will be able to hear the
station 'broadcast' sound effect.
History
Date User Action Args
2012-01-03 11:55:26Jessesetstatus: need-eg -> done-cbb
assignedto: jon -> Jesse
messages: + msg1099
2006-11-05 22:48:23Jessesetmessages: + msg138
2006-11-05 21:29:43jonsetstatus: chatting -> need-eg
assignedto: jon
nosy: + jon
2006-11-05 10:16:50jonsetstatus: unread -> chatting
messages: + msg135
2006-11-04 18:49:19Jessecreate